From 0e4f552be213edefcc6a708b9b06b391794490ca Mon Sep 17 00:00:00 2001
From: TorchedSammy <38820196+TorchedSammy@users.noreply.github.com>
Date: Sat, 12 Mar 2022 21:43:02 -0400
Subject: [PATCH] refactor: panic in history.go for more context

---
 history.go | 8 ++++----
 rl.go      | 6 +-----
 2 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/history.go b/history.go
index 8d8b947..637a8c4 100644
--- a/history.go
+++ b/history.go
@@ -12,11 +12,11 @@ type fileHistory struct {
 	f *os.File
 }
 
-func newFileHistory() (*fileHistory, error) {
+func newFileHistory() *fileHistory {
 	data, err := os.ReadFile(defaultHistPath)
 	if err != nil {
 		if !errors.Is(err, fs.ErrNotExist) {
-			return nil, err
+			panic(err)
 		}
 	}
 
@@ -30,7 +30,7 @@ func newFileHistory() (*fileHistory, error) {
 	}
 	f, err := os.OpenFile(defaultHistPath, os.O_APPEND | os.O_WRONLY | os.O_CREATE, 0755)
 	if err != nil {
-		return nil, err
+		panic(err)
 	}
 
 	fh := &fileHistory{
@@ -38,7 +38,7 @@ func newFileHistory() (*fileHistory, error) {
 		f: f,
 	}
 
-	return fh, nil
+	return fh
 }
 
 func (h *fileHistory) Write(line string) (int, error) {
diff --git a/rl.go b/rl.go
index 9013da9..280a6ac 100644
--- a/rl.go
+++ b/rl.go
@@ -20,11 +20,7 @@ func newLineReader(prompt string, noHist bool) *lineReader {
 	// we don't mind hilbish.read rl instances having completion,
 	// but it cant have shared history
 	if !noHist {
-		fh, err := newFileHistory()
-		fileHist = fh // go stupid
-		if err != nil {
-			panic(err)
-		}
+		fileHist = newFileHistory()
 		rl.SetHistoryCtrlR("file", fileHist)
 		rl.HistoryAutoWrite = false
 	}