From 7434d270e497809fbcc674edc2cda5d6c03876aa Mon Sep 17 00:00:00 2001 From: TorchedSammy <38820196+TorchedSammy@users.noreply.github.com> Date: Sun, 17 Jul 2022 18:25:19 -0400 Subject: [PATCH] perf(readline): make completion group with passed suggestions instead of looping over history twice --- readline/instance.go | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/readline/instance.go b/readline/instance.go index 01a792e..73c667d 100644 --- a/readline/instance.go +++ b/readline/instance.go @@ -231,9 +231,13 @@ func NewInstance() *Instance { rl.evtKeyPress = make(map[string]func(string, []rune, int) *EventReturn) rl.TempDirectory = os.TempDir() - rl.HistorySearcher = func(filter string) []string { - grps := rl.completeHistory() - return grps[0].filterSuggestions(rl) + rl.HistorySearcher = func(filter string, suggestions []string) []string { + grp := CompletionGroup{ + DisplayType: TabDisplayMap, + MaxLength: 10, + Suggestions: suggestions, + } + return grp.filterSuggestions(rl) } // Registers rl.initRegisters()