From 9e2d77d138c89901503a07993dba26d99ce04768 Mon Sep 17 00:00:00 2001
From: TorchedSammy <38820196+TorchedSammy@users.noreply.github.com>
Date: Mon, 5 Dec 2022 18:57:59 -0400
Subject: [PATCH] docs: add ability to document properties (and document
 hilbish.userDir)

---
 api.go               |  5 +---
 cmd/docgen/docgen.go | 57 ++++++++++++++++++++++++++++++++++++++++----
 userdir.go           | 23 ++++++++++++++++++
 3 files changed, 77 insertions(+), 8 deletions(-)
 create mode 100644 userdir.go

diff --git a/api.go b/api.go
index a0d5346..246afc9 100644
--- a/api.go
+++ b/api.go
@@ -114,10 +114,7 @@ func hilbishLoad(rtm *rt.Runtime) (rt.Value, func()) {
 	util.Document(fakeMod, "Hilbish's core API, containing submodules and functions which relate to the shell itself.")
 
 	// hilbish.userDir table
-	hshuser := rt.NewTable()
-
-	util.SetField(rtm, hshuser, "config", rt.StringValue(confDir), "User's config directory")
-	util.SetField(rtm, hshuser, "data", rt.StringValue(userDataDir), "XDG data directory")
+	hshuser := userDirLoader(rtm)
 	util.Document(hshuser, "User directories to store configs and/or modules.")
 	mod.Set(rt.StringValue("userDir"), rt.TableValue(hshuser))
 
diff --git a/cmd/docgen/docgen.go b/cmd/docgen/docgen.go
index 6372101..aa8c741 100644
--- a/cmd/docgen/docgen.go
+++ b/cmd/docgen/docgen.go
@@ -29,6 +29,7 @@ type emmyPiece struct {
 
 type module struct {
 	Docs []docPiece
+	Properties []docPiece
 	ShortDescription string
 	Description string
 	ParentModule string
@@ -44,6 +45,12 @@ type docPiece struct {
 	GoFuncName string
 	IsInterface bool
 	IsMember bool
+	Properties []docPiece
+}
+
+type tag struct {
+	id string
+	fields []string
 }
 
 var docs = make(map[string]module)
@@ -67,11 +74,31 @@ func setupDoc(mod string, fun *doc.Func) *docPiece {
 
 	pts := strings.Split(docs, "\n")
 	parts := []string{}
-	tags := make(map[string][]string)
+	tags := make(map[string][]tag)
 	for _, part := range pts {
 		if strings.HasPrefix(part, "#") {
 			tagParts := strings.Split(strings.TrimPrefix(part, "#"), " ")
-			tags[tagParts[0]] = tagParts[1:]
+			if tags[tagParts[0]] == nil {
+				var id string
+				if len(tagParts) > 1 {
+					id = tagParts[1]
+				}
+				tags[tagParts[0]] = []tag{
+					{id: id},
+				}
+				if len(tagParts) >= 2 {
+					tags[tagParts[0]][0].fields = tagParts[2:]
+				}
+			} else {
+				fleds := []string{}
+				if len(tagParts) >= 2 {
+					fleds = tagParts[2:]
+				}
+				tags[tagParts[0]] = append(tags[tagParts[0]], tag{
+					id: tagParts[1],
+					fields: fleds,
+				})
+			}
 		} else {
 			parts = append(parts, part)
 		}
@@ -84,11 +111,20 @@ func setupDoc(mod string, fun *doc.Func) *docPiece {
 	funcdoc := []string{}
 
 	if inInterface {
-		interfaces = tags["interface"][0]
+		interfaces = tags["interface"][0].id
 		funcName = interfaces + "." + strings.Split(funcsig, "(")[0]
 	}
 	em := emmyPiece{FuncName: funcName}
 
+	// manage properties
+	properties := []docPiece{}
+	for _, tag := range tags["property"] {
+		properties = append(properties, docPiece{
+			FuncName: tag.id,
+			Doc: tag.fields,
+		})
+	}
+
 	for _, d := range doc {
 		if strings.HasPrefix(d, "---") {
 			emmyLine := strings.TrimSpace(strings.TrimPrefix(d, "---"))
@@ -123,6 +159,7 @@ func setupDoc(mod string, fun *doc.Func) *docPiece {
 		IsInterface: inInterface,
 		IsMember: isMember,
 		ParentModule: parentMod,
+		Properties: properties,
 	}
 	if strings.HasSuffix(dps.GoFuncName, strings.ToLower("loader")) {
 		dps.Doc = parts
@@ -216,6 +253,7 @@ func main() {
 				desc := piece.Doc[1:]
 				interfaceModules[modname].ShortDescription = shortDesc
 				interfaceModules[modname].Description = strings.Join(desc, "\n")
+				interfaceModules[modname].Properties = piece.Properties
 				continue
 			}
 			interfaceModules[modname].Docs = append(interfaceModules[modname].Docs, piece)
@@ -256,7 +294,18 @@ func main() {
 
 			f, _ := os.Create(docPath)
 			f.WriteString(fmt.Sprintf(header, modOrIface, modname, modu.ShortDescription))
-			f.WriteString(fmt.Sprintf("## Introduction\n%s\n\n## Functions\n", modu.Description))
+			f.WriteString(fmt.Sprintf("## Introduction\n%s\n\n", modu.Description))
+			if len(modu.Properties) != 0 {
+				f.WriteString("## Properties\n")
+				for _, dps := range modu.Properties {
+					f.WriteString(fmt.Sprintf("- `%s`: ", dps.FuncName))
+					f.WriteString(strings.Join(dps.Doc, " "))
+					f.WriteString("\n")
+				}
+			}
+			if len(modu.Docs) != 0 {
+				f.WriteString("## Functions\n")
+			}
 			for _, dps := range modu.Docs {
 				f.WriteString(fmt.Sprintf("### %s\n", dps.FuncSig))
 				for _, doc := range dps.Doc {
diff --git a/userdir.go b/userdir.go
new file mode 100644
index 0000000..a4d2c51
--- /dev/null
+++ b/userdir.go
@@ -0,0 +1,23 @@
+package main
+
+import (
+	"hilbish/util"
+
+	rt "github.com/arnodel/golua/runtime"
+)
+
+// #interface userDir
+// user-related directories
+// This interface just contains properties to know about certain user directories.
+// It is equivalent to XDG on Linux and gets the user's preferred directories
+// for configs and data.
+// #property config The user's config directory
+// #property data The user's directory for program data
+func userDirLoader(rtm *rt.Runtime) *rt.Table {
+	mod := rt.NewTable()
+
+	util.SetField(rtm, mod, "config", rt.StringValue(confDir), "User's config directory")
+	util.SetField(rtm, mod, "data", rt.StringValue(userDataDir), "XDG data directory")
+
+	return mod
+}