From 5220d9bfad53d382071bbac4acfe5da625953e23 Mon Sep 17 00:00:00 2001 From: vilmibm Date: Fri, 11 Oct 2019 22:53:39 +0000 Subject: [PATCH] atomic user creation/notification --- ttadmin/users/models.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/ttadmin/users/models.py b/ttadmin/users/models.py index 392e2d2..78fc98f 100644 --- a/ttadmin/users/models.py +++ b/ttadmin/users/models.py @@ -246,9 +246,13 @@ def on_townie_pre_save(sender, instance, **kwargs): # See if we need to create the user on disk. if existing.unreviewed and instance.accepted: logger.info('Creating user {} on disk.'.format(instance.username)) - instance.create_on_disk() - instance.send_welcome_email() - instance.write_authorized_keys() + try: + instance.create_on_disk() + instance.write_authorized_keys() + except Exception as e: + logger.error('Failed syncing user {} to disk: {}'.format(instance.username, e) + else: + instance.send_welcome_email() return else: # This user state transition is currently undefined. In the future, we can check for things