fix: handle completion info check error (#330)

* fix: handle completion info check error
fixes Rosettea/Hilbish#329

* make changelog more descriptive
master
CelestialCrafter 2024-11-22 18:20:43 -06:00 committed by GitHub
parent ac7c97442e
commit 36ce05e85a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 9 additions and 2 deletions

View File

@ -1,5 +1,9 @@
# 🎀 Changelog # 🎀 Changelog
## Unreleased
### Fixed
- Skip over file and prevent panic if info cannot be retrieved during file completion (due to permission error or anything else)
## [2.3.3] - 2024-11-04 ## [2.3.3] - 2024-11-04
### Fixed ### Fixed
- Heredocs having issues - Heredocs having issues

View File

@ -157,9 +157,12 @@ func matchPath(query string) ([]string, string) {
files, _ := os.ReadDir(path) files, _ := os.ReadDir(path)
for _, entry := range files { for _, entry := range files {
// should we handle errors here?
file, err := entry.Info() file, err := entry.Info()
if err == nil && file.Mode() & os.ModeSymlink != 0 { if err != nil {
continue
}
if file.Mode() & os.ModeSymlink != 0 {
path, err := filepath.EvalSymlinks(filepath.Join(path, file.Name())) path, err := filepath.EvalSymlinks(filepath.Join(path, file.Name()))
if err == nil { if err == nil {
file, err = os.Lstat(path) file, err = os.Lstat(path)