Merge a24bca32580f88bc63a1ff15dfacc86673f03a59 into 36ce05e85a862f12b206a4a336fba94834f7372c

* fix: handle completion info check error
fixes Rosettea/Hilbish#329

* make changelog more descriptive

CHANGELOG.md

@@ -1,5 +1,9 @@
 # 🎀 Changelog
 
+## Unreleased
+### Fixed
+- Skip over file and prevent panic if info cannot be retrieved during file completion (due to permission error or anything else)
+
 ## [2.3.3] - 2024-11-04
 ### Fixed
 - Heredocs having issues

complete.go

@@ -157,9 +157,12 @@ func matchPath(query string) ([]string, string) {
 
 	files, _ := os.ReadDir(path)
 	for _, entry := range files {
-		// should we handle errors here?
 		file, err := entry.Info()
-		if err == nil && file.Mode() & os.ModeSymlink != 0 {
+		if err != nil {
+			continue
+		}
+
+		if file.Mode() & os.ModeSymlink != 0 {
 			path, err := filepath.EvalSymlinks(filepath.Join(path, file.Name()))
 			if err == nil {
 				file, err = os.Lstat(path)

nature/env.lua

@@ -0,0 +1,10 @@
+env = {}
+
+setmetatable(env, {
+	__index = function(_, k)
+		return os.getenv(k)
+	end,
+	__newindex = function(_, k, v)
+		os.setenv(k, tostring(v))
+	end
+})

nature/init.lua

@@ -24,6 +24,7 @@ require 'nature.opts'
 require 'nature.vim'
 require 'nature.runner'
 require 'nature.hummingbird'
+require 'nature.env'
 
 local shlvl = tonumber(os.getenv 'SHLVL')
 if shlvl ~= nil then
@@ -32,36 +33,6 @@ else
 	os.setenv('SHLVL', '0')
 end
 
-do
-	local virt_G = { }
-
-	setmetatable(_G, {
-		__index = function (_, key)
-			local got_virt = virt_G[key]
-			if got_virt ~= nil then
-				return got_virt
-			end
-
-			if type(key) == 'string' then
-				virt_G[key] = os.getenv(key)
-			end
-			return virt_G[key]
-		end,
-
-		__newindex = function (_, key, value)
-			if type(value) == 'string' then
-				os.setenv(key, value)
-				virt_G[key] = value
-			else
-				if type(virt_G[key]) == 'string' then
-					os.setenv(key, '')
-				end
-				virt_G[key] = value
-			end
-		end,
-	})
-end
-
 do
 	local startSearchPath = hilbish.userDir.data .. '/hilbish/start/?/init.lua;'
 	.. hilbish.userDir.data .. '/hilbish/start/?.lua'