2
2
mirror of https://github.com/Hilbis/Hilbish synced 2025-04-21 21:13:22 +00:00

Compare commits

..

2 Commits

Author SHA1 Message Date
ab08232a71
Merge a59394ec2be1b936b4fd4ffd45f8b4f2b8c8c84a into 36ce05e85a862f12b206a4a336fba94834f7372c 2024-11-30 15:00:47 -03:00
CelestialCrafter
36ce05e85a
fix: handle completion info check error (#330)
* fix: handle completion info check error
fixes Rosettea/Hilbish#329

* make changelog more descriptive
2024-11-22 20:20:43 -04:00
2 changed files with 9 additions and 2 deletions

View File

@ -1,5 +1,9 @@
# 🎀 Changelog # 🎀 Changelog
## Unreleased
### Fixed
- Skip over file and prevent panic if info cannot be retrieved during file completion (due to permission error or anything else)
## [2.3.3] - 2024-11-04 ## [2.3.3] - 2024-11-04
### Fixed ### Fixed
- Heredocs having issues - Heredocs having issues

View File

@ -157,9 +157,12 @@ func matchPath(query string) ([]string, string) {
files, _ := os.ReadDir(path) files, _ := os.ReadDir(path)
for _, entry := range files { for _, entry := range files {
// should we handle errors here?
file, err := entry.Info() file, err := entry.Info()
if err == nil && file.Mode() & os.ModeSymlink != 0 { if err != nil {
continue
}
if file.Mode() & os.ModeSymlink != 0 {
path, err := filepath.EvalSymlinks(filepath.Join(path, file.Name())) path, err := filepath.EvalSymlinks(filepath.Join(path, file.Name()))
if err == nil { if err == nil {
file, err = os.Lstat(path) file, err = os.Lstat(path)