feat: emit job.add hook when job is added

job.go

@@ -1,9 +1,10 @@
 package main
 
 import (
-	"sync"
+	"io"
 	"os"
 	"os/exec"
+	"sync"
 
 	"hilbish/util"
 
@@ -25,9 +26,9 @@ type job struct {
 	// would just be so itll be the same binary command always (path changes)
 	path string
 	handle *exec.Cmd
-	stdin *iolib.File
+	stdin io.Reader
-	stdout *iolib.File
+	stdout io.Writer
-	stderr *iolib.File
+	stderr io.Writer
 }
 
 func (j *job) start() error {
@@ -36,9 +37,9 @@ func (j *job) start() error {
 		cmd := exec.Cmd{
 			Path: j.path,
 			Args: j.args,
-			Stdin: j.getStdio("in"),
+			Stdin: j.stdin,
-			Stdout: j.getStdio("out"),
+			Stdout: j.stdout,
-			Stderr: j.getStdio("err"),
+			Stderr: j.stderr,
 		}
 		j.setHandle(&cmd)
 	}
@@ -75,6 +76,9 @@ func (j *job) setHandle(handle *exec.Cmd) {
 	j.handle = handle
 	j.args = handle.Args
 	j.path = handle.Path
+	j.stdin = handle.Stdin
+	j.stdout = handle.Stdout
+	j.stderr = handle.Stderr
 }
 
 func (j *job) getProc() *os.Process {
@@ -86,17 +90,12 @@ func (j *job) getProc() *os.Process {
 	return nil
 }
 
-func (j *job) getStdio(typ string) *os.File {
+func (j *job) setStdio(typ string, f *iolib.File) {
-	// TODO: make this use std io/out/err values from job struct,
-	// which are lua files
-	var stdio *os.File
 	switch typ {
-		case "in": stdio = os.Stdin
+		case "in": j.stdin = f.File
-		case "out": stdio = os.Stdout
+		case "out": j.stdout = f.File
-		case "err": stdio = os.Stderr
+		case "err": j.stderr = f.File
 	}
-
-	return stdio
 }
 
 func (j *job) lua() rt.Value {
@@ -160,8 +159,13 @@ func (j *jobHandler) add(cmd string, args []string, path string) *job {
 		running: false,
 		id: j.latestID,
 		args: args,
+		path: path,
+		stdin: os.Stdin,
+		stdout: os.Stdout,
+		stderr: os.Stderr,
 	}
 	j.jobs[j.latestID] = jb
+	hooks.Em.Emit("job.add", jb.lua())
 
 	return jb
 }
@@ -177,7 +181,7 @@ func (j *jobHandler) loader(rtm *rt.Runtime) *rt.Table {
 	jobFuncs := map[string]util.LuaExport{
 		"all": {j.luaAllJobs, 0, false},
 		"get": {j.luaGetJob, 1, false},
-		"add": {j.luaAddJob, 1, false},
+		"add": {j.luaAddJob, 2, false},
 	}
 
 	luaJob := rt.NewTable()
@@ -207,10 +211,7 @@ func (j *jobHandler) luaGetJob(t *rt.Thread, c *rt.GoCont) (rt.Cont, error) {
 }
 
 func (j *jobHandler) luaAddJob(t *rt.Thread, c *rt.GoCont) (rt.Cont, error) {
-	j.mu.RLock()
+	if err := c.CheckNArgs(2); err != nil {
-	defer j.mu.RUnlock()
-
-	if err := c.Check1Arg(); err != nil {
 		return nil, err
 	}
 	cmd, err := c.StringArg(0)