Merge 2af38c3bab into ee1ed077b9

fixes #252

CHANGELOG.md

@@ -22,10 +22,8 @@ completed.
   navigation of neighboring doc files.
 
 ### Fixed
-- Return the prefix when calling `hilbish.completions.call`
+- Fix infinite loop when navigating history without any history. [#252](https://github.com/Rosettea/Hilbish/issues/252)
-
+- Return the prefix when calling `hilbish.completions.call`. [#219](https://github.com/Rosettea/Hilbish/issues/219)
-[#219]: https://github.com/Rosettea/Hilbish/issues/219
-### Fixed
 - Replaced `sed` in-place editing with `grep` and `mv` for compatibility with BSD utils
 
 ## [2.1.2] - 2022-04-10

readline/history.go

@@ -156,8 +156,8 @@ func (rl *Instance) walkHistory(i int) {
 	rl.updateHelpers()
 
 	// In order to avoid having to type j/k twice each time for history navigation,
-	// we walk once again. This only ever happens when we aren't out of bounds.
+	// we walk once again. This only ever happens when we aren't out of bounds and the last history item was not a empty string.
-	if dedup && old == new {
+	if new != "" && dedup && old == new {
 		rl.walkHistory(i)
 	}
 }