Python 3.13: Fix and polish #1

noelle · 2025-06-02T21:35:58Z

noelle commented

2025-06-02 21:35:58 +00:00

I gave the script a pretty thorough cleanup by removing commented code, replacing deprecated functions, turning multiple print()s into a single one, using modern libraries for path manipulation...
I tried to avoid entirely re-implementing its features for now.
Each change has been broken into its own commit, so I recommend stepping through them to get a sense of each individual diff.

Future improvements I'd like to make:

Use argparse to handle CLI.
Instead of moving the big train string, put it on a pad, and move the cropped view of the pad from left to right.
Better on-boarding for new users.

I gave the script a pretty thorough cleanup by removing commented code, replacing deprecated functions, turning multiple `print()`s into a single one, using modern libraries for path manipulation... I tried to avoid entirely re-implementing its features for now. Each change has been broken into its own commit, so I recommend stepping through them to get a sense of each individual diff. Future improvements I'd like to make: - Use [argparse](https://docs.python.org/3/library/argparse.html) to handle CLI. - Instead of moving the big train string, put it on a [pad](https://docs.python.org/3/library/curses.html#curses.newpad), and move the cropped view of the pad from left to right. - Better on-boarding for new users.

noelle added 15 commits 2025-06-02 21:35:58 +00:00

Use r-strings for embedded train car art c8d49bda3d

That fixes these SyntaxWarnings:

tilde-train.py:60: SyntaxWarning: invalid escape sequence '\_'
  |  |              | |__/V\_| |
tilde-train.py:76: SyntaxWarning: invalid escape sequence '\-'
  == - /  \-/  \-----/  \-/  \ - ==
tilde-train.py:86: SyntaxWarning: invalid escape sequence '\-'
  - /  \-/  \------/  \-/  \ -

Update details in file header for the fork. 29a8ffa91e

Also remove trailing whitespace in the header.

Rewrite car templates as list of strings 6d4e7c7914

This lets us trim all the trailing whitespace in the file automatically.

Rewrite print_help to a single string 7a74050c5d

replace exit() and quit() with sys.exit() 4cc4b2ead4

Use pathlib in test_user_car 8441c6acfb

Add type hints to function signatures fc80d291ab

For better code intelligence

Make each default car a separate list in memory 56f7c8d278

So the link strings don't just grow over time

validate_car: Don't reassign input variable 681fa6514c

This makes it easier to track what's happening in the function

Add type hint for cars 2ba6a9c0ca

Replace double # with single 93a8273b6d

Remove commented code db1464c2d2

Add better error handling for curses failures a07aa2685b

Make validate_car raise exception on failure instead of returning 0 0b53c462de

Escape HTML characters when printing the train 6063c8b3b3

Since it's wrapped in a `<pre>`, I assume it's meant to be inserted into
HTML?

vilmibm approved these changes 2025-06-02 22:23:08 +00:00

vilmibm left a comment

<3__<3

vilmibm merged commit dcccaebbab into trunk

2025-06-02 22:23:23 +00:00

vilmibm referenced this issue from a commit

2025-06-02 22:23:24 +00:00

Merge pull request 'Python 3.13: Fix and polish' (#1) from noelle/tilde-train:python-3.13 into trunk

noelle deleted branch python-3.13

2025-06-04 22:43:53 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: vilmibm/tilde-train#1